PCI updates for v4.1:

  Resource management
    - ia64: Treat all Address Space Descriptors as windows (Bjorn Helgaas)

  Miscellaneous
    - MAINTAINERS: Remove Mohit Kumar (email bounces) (Bjorn Helgaas)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJVN7vCAAoJEFmIoMA60/r8ZPUP/AgGrsy7BiDfPM5n7T7DSaAV
GUeg12cU7s3M5sBk6XUktxpB1AwZuoDrtWe6srMz5H7Q/I9JTiybxEvkRUjXWJbV
SfOShRwS3JyQAy8G/Ld0idEzDQDcXBAX4uom8xRwpLW/bTPwCCqmHCQnuvK20jbp
7S3Snl5j/y6ihiX4Mo6J1Bu88CpJeAq/LQ4WBKd0SEXtSuSRkwGO1TPGi1B7vNxp
YcFM4QSbc/2z+K51RL5ieovJZ71fFpJrFZt1H+f+SBwN5hXDsub6NB8Mj1MyV/bn
BwoX9ebagSVC5x2LKmwjfCVGMAy1LO3qkYkQ6QQ/56b2YyafzG7GRHkkNE3bNdu1
p19IZ8uQG/zr5kcwFy6TF9d2nCPmFgjAbWWXgt60pGj5XnO2TOCmcduWmywkS8ld
xeLeF3SeDuIo1+nL2egNX4ig5pJhhbVYpMgDa+JyFFx/K0at/pl1F6xAVxm2SNPn
6GVWVXDM4uyksCXeMpPuOtj2bNP3mUloTViDeNPycJwqij+bkrU6VB+nKwBb6iup
1w2PHOV+94urwqHMI5mdLKdIE2p1a35ks9lT5S2xiWsNf8FCb9DNqqymRRjnNlQk
IIPFqVleV0rOnsjfHY0SyIRXinXf2f3CYTCYSyl77Zc6UObrC2v7G2SbHKieWy+B
XYsHftw60GQAfEZRj9aq
=anh8
-----END PGP SIGNATURE-----
ia64/PCI: Treat all host bridge Address Space Descriptors (even consumers) as windows

Prior to c770cb4cb505 ("PCI: Mark invalid BARs as unassigned"), if we tried
to claim a PCI BAR but could not find an upstream bridge window that
matched it, we complained but still allowed the device to be enabled.

c770cb4cb505 broke devices that previously worked (mptsas and igb in the
case Tony reported, but it could be any devices) because it marks those
BARs as IORESOURCE_UNSET, which makes pci_enable_device() complain and
return failure:

  igb 0000:81:00.0: can't enable device: BAR 0 [mem size 0x00020000] not assigned
  igb: probe of 0000:81:00.0 failed with error -22

The underlying cause is an ACPI Address Space Descriptor for a PCI host
bridge window that is marked as "consumer".  This is a firmware defect:
resources that are produced on the downstream side of a bridge should be
marked "producer".  But rejecting these BARs that we previously allowed is
a functionality regression, and firmware has not used the producer/consumer
bit consistently, so we can't rely on it anyway.

Stop checking the producer/consumer bit, and assume all bridge Address
Space Descriptors are for bridge windows.

Note that this change does not affect I/O Port or Fixed Location I/O Port
Descriptors, which are commonly used for the [io 0x0cf8-0x0cff] config
access range.  That range is a "consumer" range and should not be treated
as a window.

Fixes: c770cb4cb505 ("PCI: Mark invalid BARs as unassigned")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=96961
Reported-and-tested-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 file changed