mm: fadvise: avoid fadvise for fs without backing device
The fadvise() manpage is silent on fadvise()'s effect on memory-based
filesystems (shmem, hugetlbfs & ramfs) and pseudo file systems (procfs,
sysfs, kernfs). The current implementaion of fadvise is mostly a noop for
such filesystems except for FADV_DONTNEED which will trigger expensive
remote LRU cache draining. This patch makes the noop of fadvise() on such
file systems very explicit.
However this change has two side effects for ramfs and one for tmpfs.
First fadvise(FADV_DONTNEED) can remove the unmapped clean zero'ed pages
of ramfs (allocated through read, readahead & read fault) and tmpfs
(allocated through read fault). Also fadvise(FADV_WILLNEED) on create
such clean zero'ed pages for ramfs. This change removes these two
interfaces.
One of our generic librarise does fadvise(FADV_DONTNEED). Recently we
observed high latency in fadvise() and noticed that the users have started
using tmpfs files and the latency was due to expensive remote LRU cache
draining. For normal tmpfs files (have data written on them),
fadvise(FADV_DONTNEED) will always trigger the unneeded remote cache
draining.
Link: http://lkml.kernel.org/r/20170818011023.181465-1-shakeelb@google.com
Signed-off-by: Shakeel Butt <shakeelb@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Hugh Dickins <hughd@google.com>
Cc: Greg Thelen <gthelen@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 file changed
