)]}'
{
  "commit": "23dd5be7e19ceab8c1c79110ee3552bcabc463ef",
  "tree": "54cb386480d5dba40bc35fbb188523b31f105a37",
  "parents": [
    "f434191f93884c9de58c38f18ac7fc7f1fdf9e42"
  ],
  "author": {
    "name": "Dimitri Daskalakis",
    "email": "daskald@meta.com",
    "time": "Fri Oct 16 17:54:01 2026 -0700"
  },
  "committer": {
    "name": "Jakub Kicinski",
    "email": "kuba@kernel.org",
    "time": "Tue Oct 20 13:50:27 2026 -0700"
  },
  "message": "net/mlx5e: Update netdev features only after a successful ringparam set\n\nmlx5 couples HW-GRO with tcp-data-split. If a user sets rx-gro-hw on -\u003e\ntcp-data-split on -\u003e rx-gro-hw off, the driver will leave HW-GRO on.\nmlx5e_ethtool_set_tcp_data_split() calls netdev_update_features() when\ntcp-data-split goes from enabled to disabled in case HW-GRO needs to be\nreleased. mlx5e_fix_features() reads the new HDS config from\ndev-\u003ecfg_pending, so HW-GRO is released before all ring parameters are\nvalidated.\n\nIf the subsequent call to mlx5e_ethtool_set_ringparam() fails, the\nethtool core discards the pending change and reports tcp-data-split\nenabled. The device is no longer splitting, and subsequent ring changes\nare blocked.\n\nMove the call to netdev_update_features() after\nmlx5e_ethtool_set_ringparam() exits successfully.\n\nThe issue was discovered by manual code inspection during review of\na change that stops mlx5 users from disabling tcp-data-split. It was\nreproduced on a ConnectX-7 with ethtool alone.\n\nSteps to reproduce:\nethtool -K eth0 rx-gro-hw on\nethtool -G eth0 tcp-data-split on\nethtool -K eth0 rx-gro-hw off # HW-GRO kept on for tcp-data-split\n\nethtool -G eth0 tcp-data-split off rx 1 # de-sync driver \u0026 kernel state\n netlink error: mlx5_core: rx (1) \u003c min (16)\n netlink error: Invalid argument\n\nethtool -G eth0 rx 1024 # valid ring changes are now blocked\n netlink error: mlx5_core: TCP-data-split is not supported when GRO HW is disabled\n netlink error: Invalid argument\n\nThis is not a terminal state, users can recover by setting rx-gro-hw on.\nWith the fix, the failing ringparam set leaves rx-gro-hw on and later\nring changes succeed.\n\nFixes: 46bcce5dfd33 (\"net/mlx5e: Support ethtool tcp-data-split settings\")\nReported-by: Björn Töpel \u003cbjorn@kernel.org\u003e\nCloses: https://lore.kernel.org/87se2grw3d.fsf@all.your.base.are.belong.to.us/\nSigned-off-by: Dimitri Daskalakis \u003cdaskald@meta.com\u003e\nReviewed-by: Björn Töpel \u003cbjorn@kernel.org\u003e\nReviewed-by: Nimrod Oren \u003cnoren@nvidia.com\u003e\nAcked-by: Tariq Toukan \u003ctariqt@nvidia.com\u003e\nLink: https://patch.msgid.link/20261017005401.1582755-1-dimitri.daskalakis1@gmail.com\nSigned-off-by: Jakub Kicinski \u003ckuba@kernel.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3ed59ced0407aa64c62abe906a4658864d7e6ce0",
      "old_mode": 33188,
      "old_path": "drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c",
      "new_id": "f38e033ab8faf07583993c4acd373cd95fd75597",
      "new_mode": 33188,
      "new_path": "drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c"
    }
  ]
}