| From 89f43cd859a34a689291902f6deb5a352c2c20d7 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@suse.de> |
| Date: Thu, 18 Nov 2010 11:21:04 -0800 |
| Subject: [PATCH] Staging: asus_oled: fix up my fixup for some sysfs attribute |
| permissions |
| |
| commit 515b4987ccd097cdf5416530b05fdf9e01afe95a upstream. |
| |
| They should be writable by root, not readable. |
| Doh, stupid me with the wrong flags. |
| |
| Reported-by: Jonathan Cameron <jic23@cam.ac.uk> |
| Cc: Jakub Schmidtke <sjakub@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c |
| index 3dd5173..5820286 100644 |
| --- a/drivers/staging/asus_oled/asus_oled.c |
| +++ b/drivers/staging/asus_oled/asus_oled.c |
| @@ -620,13 +620,13 @@ static ssize_t class_set_picture(struct device *device, |
| |
| #define ASUS_OLED_DEVICE_ATTR(_file) dev_attr_asus_oled_##_file |
| |
| -static DEVICE_ATTR(asus_oled_enabled, S_IRUSR | S_IRUGO, |
| +static DEVICE_ATTR(asus_oled_enabled, S_IWUSR | S_IRUGO, |
| get_enabled, set_enabled); |
| -static DEVICE_ATTR(asus_oled_picture, S_IRUSR , NULL, set_picture); |
| +static DEVICE_ATTR(asus_oled_picture, S_IWUSR , NULL, set_picture); |
| |
| -static DEVICE_ATTR(enabled, S_IRUSR | S_IRUGO, |
| +static DEVICE_ATTR(enabled, S_IWUSR | S_IRUGO, |
| class_get_enabled, class_set_enabled); |
| -static DEVICE_ATTR(picture, S_IRUSR, NULL, class_set_picture); |
| +static DEVICE_ATTR(picture, S_IWUSR, NULL, class_set_picture); |
| |
| static int asus_oled_probe(struct usb_interface *interface, |
| const struct usb_device_id *id) |
| -- |
| 1.7.4.4 |
| |
