| From 1a13e5522d6a9c7fbc28b0b3541dc093db0053a8 Mon Sep 17 00:00:00 2001 |
| From: Li Zefan <lizf@cn.fujitsu.com> |
| Date: Thu, 11 Mar 2010 14:08:10 -0800 |
| Subject: [PATCH] sunrpc/cache: fix module refcnt leak in a failure path |
| |
| commit a5990ea1254cd186b38744507aeec3136a0c1c95 upstream |
| |
| Don't forget to release the module refcnt if seq_open() returns failure. |
| |
| Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> |
| Cc: J. Bruce Fields <bfields@fieldses.org> |
| Cc: Neil Brown <neilb@suse.de> |
| Cc: Trond Myklebust <Trond.Myklebust@netapp.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c |
| index 39bddba..b7af6b2 100644 |
| --- a/net/sunrpc/cache.c |
| +++ b/net/sunrpc/cache.c |
| @@ -1233,8 +1233,10 @@ static int content_open(struct inode *inode, struct file *file, |
| if (!cd || !try_module_get(cd->owner)) |
| return -EACCES; |
| han = __seq_open_private(file, &cache_content_op, sizeof(*han)); |
| - if (han == NULL) |
| + if (han == NULL) { |
| + module_put(cd->owner); |
| return -ENOMEM; |
| + } |
| |
| han->cd = cd; |
| return 0; |
| -- |
| 1.7.4.4 |
| |
