| From ae20d914966225feec63dd00ef516a58a8885be7 Mon Sep 17 00:00:00 2001 |
| From: Krzysztof Kozlowski <krzk@kernel.org> |
| Date: Sat, 7 Jan 2017 10:41:40 +0200 |
| Subject: [PATCH] usb: host: ehci-exynos: Decrese node refcount on |
| exynos_ehci_get_phy() error paths |
| |
| commit 3f6026b1dcb3c8ee71198c485a72ac674c6890dd upstream. |
| |
| Returning from for_each_available_child_of_node() loop requires cleaning |
| up node refcount. Error paths lacked it so for example in case of |
| deferred probe, the refcount of phy node was left increased. |
| |
| Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs") |
| Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> |
| Acked-by: Alan Stern <stern@rowland.harvard.edu> |
| Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c |
| index 42e5b66353ef..7a603f66a9bc 100644 |
| --- a/drivers/usb/host/ehci-exynos.c |
| +++ b/drivers/usb/host/ehci-exynos.c |
| @@ -77,10 +77,12 @@ static int exynos_ehci_get_phy(struct device *dev, |
| if (IS_ERR(phy)) { |
| ret = PTR_ERR(phy); |
| if (ret == -EPROBE_DEFER) { |
| + of_node_put(child); |
| return ret; |
| } else if (ret != -ENOSYS && ret != -ENODEV) { |
| dev_err(dev, |
| "Error retrieving usb2 phy: %d\n", ret); |
| + of_node_put(child); |
| return ret; |
| } |
| } |
| -- |
| 2.12.0 |
| |
