| From 95065a61e9bf25fb85295127fba893200c2bbbd8 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Wed, 29 Mar 2017 18:15:27 +0200 |
| Subject: [PATCH] Bluetooth: hci_bcm: add missing tty-device sanity check |
| |
| commit 95065a61e9bf25fb85295127fba893200c2bbbd8 upstream. |
| |
| Make sure to check the tty-device pointer before looking up the sibling |
| platform device to avoid dereferencing a NULL-pointer when the tty is |
| one end of a Unix98 pty. |
| |
| Fixes: 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices") |
| Cc: stable <stable@vger.kernel.org> # 4.3 |
| Cc: Frederic Danis <frederic.danis@linux.intel.com> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
| |
| diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c |
| index 04fe5535a153..f87bfdfee4ff 100644 |
| --- a/drivers/bluetooth/hci_bcm.c |
| +++ b/drivers/bluetooth/hci_bcm.c |
| @@ -287,6 +287,9 @@ static int bcm_open(struct hci_uart *hu) |
| |
| hu->priv = bcm; |
| |
| + if (!hu->tty->dev) |
| + goto out; |
| + |
| mutex_lock(&bcm_device_lock); |
| list_for_each(p, &bcm_device_list) { |
| struct bcm_device *dev = list_entry(p, struct bcm_device, list); |
| @@ -307,7 +310,7 @@ static int bcm_open(struct hci_uart *hu) |
| } |
| |
| mutex_unlock(&bcm_device_lock); |
| - |
| +out: |
| return 0; |
| } |
| |
| -- |
| 2.12.0 |
| |
