| From d66777caa57ffade6061782f3a4d4056f0b0c1ac Mon Sep 17 00:00:00 2001 |
| From: Guenter Roeck <linux@roeck-us.net> |
| Date: Wed, 8 Feb 2017 14:05:56 -0800 |
| Subject: [PATCH] hwmon: (it87) Fix pwm4 detection for IT8620 and IT8628 |
| |
| commit d66777caa57ffade6061782f3a4d4056f0b0c1ac upstream. |
| |
| pwm4 is enabled if bit 2 of GPIO control register 4 is disabled, |
| not when it is enabled. Since the check is for the skip condition, |
| it is reversed. This applies to both IT8620 and IT8628. |
| |
| Fixes: 36c4d98a7883d ("hwmon: (it87) Add support for all pwm channels ...") |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| |
| diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c |
| index 85918d8a747a..4f3fabcd470d 100644 |
| --- a/drivers/hwmon/it87.c |
| +++ b/drivers/hwmon/it87.c |
| @@ -2614,7 +2614,7 @@ static int __init it87_find(int sioaddr, unsigned short *address, |
| |
| /* Check for pwm4 */ |
| reg = superio_inb(sioaddr, IT87_SIO_GPIO4_REG); |
| - if (!(reg & BIT(2))) |
| + if (reg & BIT(2)) |
| sio_data->skip_pwm |= BIT(3); |
| |
| /* Check for pwm2, fan2 */ |
| -- |
| 2.12.0 |
| |
