| From 0ff899613701d1e59e23eedb641de875d9d0fd6a Mon Sep 17 00:00:00 2001 |
| From: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Date: Fri, 24 Feb 2017 16:04:15 +0200 |
| Subject: [PATCH] intel_th: Don't leak module refcount on failure to activate |
| |
| commit e609ccef5222c73b46b322be7d3796d60bff353d upstream. |
| |
| Output 'activation' may fail for the reasons of the output driver, |
| for example, if msc's buffer is not allocated. We forget, however, |
| to drop the module reference in this case. So each attempt at |
| activation in this case leaks a reference, preventing the module |
| from ever unloading. |
| |
| This patch adds the missing module_put() in the activation error |
| path. |
| |
| Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Cc: stable@vger.kernel.org # v4.8+ |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c |
| index 6f0a51a2c6ec..d439736c789b 100644 |
| --- a/drivers/hwtracing/intel_th/core.c |
| +++ b/drivers/hwtracing/intel_th/core.c |
| @@ -218,8 +218,10 @@ static int intel_th_output_activate(struct intel_th_device *thdev) |
| else |
| intel_th_trace_enable(thdev); |
| |
| - if (ret) |
| + if (ret) { |
| pm_runtime_put(&thdev->dev); |
| + module_put(thdrv->driver.owner); |
| + } |
| |
| return ret; |
| } |
| -- |
| 2.12.0 |
| |
