| From b97909807eeeb6fe50461a14fc0188e999f8066e Mon Sep 17 00:00:00 2001 |
| From: Max Lohrmann <post@wickenrode.com> |
| Date: Tue, 7 Mar 2017 22:09:56 -0800 |
| Subject: [PATCH] target: Fix VERIFY_16 handling in sbc_parse_cdb |
| |
| commit 13603685c1f12c67a7a2427f00b63f39a2b6f7c9 upstream. |
| |
| As reported by Max, the Windows 2008 R2 chkdsk utility expects |
| VERIFY_16 to be supported, and does not handle the returned |
| CHECK_CONDITION properly, resulting in an infinite loop. |
| |
| The kernel will log huge amounts of this error: |
| |
| kernel: TARGET_CORE[iSCSI]: Unsupported SCSI Opcode 0x8f, sending |
| CHECK_CONDITION. |
| |
| Signed-off-by: Max Lohrmann <post@wickenrode.com> |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c |
| index aabd6602da6c..a53fb23a0411 100644 |
| --- a/drivers/target/target_core_sbc.c |
| +++ b/drivers/target/target_core_sbc.c |
| @@ -1104,9 +1104,15 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) |
| return ret; |
| break; |
| case VERIFY: |
| + case VERIFY_16: |
| size = 0; |
| - sectors = transport_get_sectors_10(cdb); |
| - cmd->t_task_lba = transport_lba_32(cdb); |
| + if (cdb[0] == VERIFY) { |
| + sectors = transport_get_sectors_10(cdb); |
| + cmd->t_task_lba = transport_lba_32(cdb); |
| + } else { |
| + sectors = transport_get_sectors_16(cdb); |
| + cmd->t_task_lba = transport_lba_64(cdb); |
| + } |
| cmd->execute_cmd = sbc_emulate_noop; |
| goto check_lba; |
| case REZERO_UNIT: |
| -- |
| 2.12.0 |
| |
