| From 21322e2a170de9bbbaea9c4014daef6aef906f9d Mon Sep 17 00:00:00 2001 |
| From: =?UTF-8?q?Horia=20Geant=C4=83?= <horia.geanta@nxp.com> |
| Date: Mon, 3 Apr 2017 18:30:07 +0300 |
| Subject: [PATCH] crypto: caam - fix invalid dereference in caam_rsa_init_tfm() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| commit 33fa46d7b310e06d2cb2ab5417c100af120bfb65 upstream. |
| |
| In case caam_jr_alloc() fails, ctx->dev carries the error code, |
| thus accessing it with dev_err() is incorrect. |
| |
| Cc: <stable@vger.kernel.org> # 4.8+ |
| Fixes: 8c419778ab57e ("crypto: caam - add support for RSA algorithm") |
| Signed-off-by: Horia Geantă <horia.geanta@nxp.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c |
| index 851015e652b8..354a16ab5a16 100644 |
| --- a/drivers/crypto/caam/caampkc.c |
| +++ b/drivers/crypto/caam/caampkc.c |
| @@ -506,7 +506,7 @@ static int caam_rsa_init_tfm(struct crypto_akcipher *tfm) |
| ctx->dev = caam_jr_alloc(); |
| |
| if (IS_ERR(ctx->dev)) { |
| - dev_err(ctx->dev, "Job Ring Device allocation for transform failed\n"); |
| + pr_err("Job Ring Device allocation for transform failed\n"); |
| return PTR_ERR(ctx->dev); |
| } |
| |
| -- |
| 2.12.0 |
| |
