blob: 084bba0b8527afd780b9bb615e0b8ba213583cfe [file] [log] [blame]
From eb6331f935b2051ce9dda25ccdab446e47636a35 Mon Sep 17 00:00:00 2001
From: Mikulas Patocka <>
Date: Mon, 20 Apr 2020 16:02:21 -0400
Subject: [PATCH] ext2: fix missing percpu_counter_inc
commit bc2fbaa4d3808aef82dd1064a8e61c16549fe956 upstream.
sbi->s_freeinodes_counter is only decreased by the ext2 code, it is never
increased. This patch fixes it.
Note that sbi->s_freeinodes_counter is only used in the algorithm that
tries to find the group for new allocations, so this bug is not easily
visible (the only visibility is that the group finding algorithm selects
inoptinal result).
Signed-off-by: Mikulas Patocka <>
Signed-off-by: Jan Kara <>
Signed-off-by: Paul Gortmaker <>
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index a0c5ea91fcd4..8c29d4d6bfd5 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -80,6 +80,7 @@ static void ext2_release_inode(struct super_block *sb, int group, int dir)
if (dir)
le16_add_cpu(&desc->bg_used_dirs_count, -1);
spin_unlock(sb_bgl_lock(EXT2_SB(sb), group));
+ percpu_counter_inc(&EXT2_SB(sb)->s_freeinodes_counter);
if (dir)
@@ -529,7 +530,7 @@ struct inode *ext2_new_inode(struct inode *dir, umode_t mode,
goto fail;
- percpu_counter_add(&sbi->s_freeinodes_counter, -1);
+ percpu_counter_dec(&sbi->s_freeinodes_counter);
if (S_ISDIR(mode))