blob: 39753e427bb2c397424db3d1ccbd4538a9e88b48 [file] [log] [blame]
From 45e81cb7c08fbdb3387863287da28c5a5442a534 Mon Sep 17 00:00:00 2001
From: Dan Williams <>
Date: Tue, 15 Oct 2019 12:54:17 -0700
Subject: [PATCH] libata/ahci: Fix PCS quirk application
commit 09d6ac8dc51a033ae0043c1fe40b4d02563c2496 upstream.
Commit c312ef176399 "libata/ahci: Drop PCS quirk for Denverton and
beyond" got the polarity wrong on the check for which board-ids should
have the quirk applied. The board type board_ahci_pcs7 is defined at the
end of the list such that "pcs7" boards can be special cased in the
future if they need the quirk. All prior Intel board ids "<
board_ahci_pcs7" should proceed with applying the quirk.
Reported-by: Andreas Friedrich <>
Reported-by: Stephen Douthit <>
Fixes: c312ef176399 ("libata/ahci: Drop PCS quirk for Denverton and beyond")
Cc: <>
Signed-off-by: Dan Williams <>
Signed-off-by: Jens Axboe <>
Signed-off-by: Paul Gortmaker <>
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 3e63294304c7..691852b8bb41 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1617,7 +1617,9 @@ static void ahci_intel_pcs_quirk(struct pci_dev *pdev, struct ahci_host_priv *hp
if (!id || id->vendor != PCI_VENDOR_ID_INTEL)
- if (((enum board_ids) id->driver_data) < board_ahci_pcs7)
+ /* Skip applying the quirk on Denverton and beyond */
+ if (((enum board_ids) id->driver_data) >= board_ahci_pcs7)