blob: 5b5df260307239f32105a3fe5b0ee4f3c809ac14 [file] [log] [blame]
From 70e6d9eafbe8ee58a645799d2de9200c237b3765 Mon Sep 17 00:00:00 2001
From: Kai Vehmanen <>
Date: Fri, 27 Sep 2019 15:05:35 -0500
Subject: [PATCH] ASoC: SOF: Intel: hda: fix warnings during FW load
commit 4ff5f6439fe69624e8f7d559915e9b54a6477684 upstream.
The "snd_pcm_substream" handle was not initialized properly
in hda-loader.c for firmware load.
When the HDA DMAs were used to load the firmware,
the interrupts related to firmware load also triggered
calls to snd_sof_pcm_period_elapsed() on a non-existent ALSA
PCM stream.
This caused runtime kernel warnings from
Signed-off-by: Kai Vehmanen <>
Signed-off-by: Pierre-Louis Bossart <>
Signed-off-by: Mark Brown <>
Signed-off-by: Paul Gortmaker <>
diff --git a/sound/soc/sof/intel/hda-loader.c b/sound/soc/sof/intel/hda-loader.c
index 6427f0b3a2f1..65c2af3fcaab 100644
--- a/sound/soc/sof/intel/hda-loader.c
+++ b/sound/soc/sof/intel/hda-loader.c
@@ -44,6 +44,7 @@ static int cl_stream_prepare(struct snd_sof_dev *sdev, unsigned int format,
return -ENODEV;
hstream = &dsp_stream->hstream;
+ hstream->substream = NULL;
/* allocate DMA buffer */
ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_SG, &pci->dev, size, dmab);