blob: 3697ccf1366c973dbd45819675d27bd8b6e14a19 [file] [log] [blame]
From 7e02cda06fd34cbb5471bfcd00a191aff3a4fda3 Mon Sep 17 00:00:00 2001
From: Michael Ellerman <>
Date: Thu, 24 Oct 2019 11:47:30 +1100
Subject: [PATCH] powerpc/tools: Don't quote $objdump in scripts
commit e44ff9ea8f4c8a90c82f7b85bd4f5e497c841960 upstream.
Some of our scripts are passed $objdump and then call it as
"$objdump". This doesn't work if it contains spaces because we're
using ccache, for example you get errors such as:
./arch/powerpc/tools/ line 48: ccache ppc64le-objdump: No such file or directory
./arch/powerpc/tools/ line 26: ccache ppc64le-objdump: No such file or directory
Fix it by not quoting the string when we expand it, allowing the shell
to do the right thing for us.
Fixes: a71aa05e1416 ("powerpc: Convert relocs_check to a shell script using grep")
Fixes: 4ea80652dc75 ("powerpc/64s: Tool to flag direct branches from unrelocated interrupt vectors")
Signed-off-by: Michael Ellerman <>
Signed-off-by: Michael Ellerman <>
Signed-off-by: Paul Gortmaker <>
diff --git a/arch/powerpc/tools/ b/arch/powerpc/tools/
index 2b4e959caa36..7b9fe0a567cf 100755
--- a/arch/powerpc/tools/
+++ b/arch/powerpc/tools/
@@ -20,7 +20,7 @@ objdump="$1"
-"$objdump" -R "$vmlinux" |
+$objdump -R "$vmlinux" |
# Only look at relocation lines.
grep -E '\<R_' |
# These relocations are okay
diff --git a/arch/powerpc/tools/ b/arch/powerpc/tools/
index 1e972df3107e..77114755dc6f 100755
--- a/arch/powerpc/tools/
+++ b/arch/powerpc/tools/
@@ -18,14 +18,14 @@ vmlinux="$2"
#__end_interrupts should be located within the first 64K
-"$objdump" -R "$vmlinux" -d --start-address=0xc000000000000000 \
+$objdump -R "$vmlinux" -d --start-address=0xc000000000000000 \
--stop-address=0xc000000000010000 |
grep '\<__end_interrupts>:' |
awk '{print $1}'
-"$objdump" -R "$vmlinux" -D --start-address=0xc000000000000000 \
+$objdump -R "$vmlinux" -D --start-address=0xc000000000000000 \
--stop-address=${end_intr} |
grep -e "^c[0-9a-f]*:[[:space:]]*\([0-9a-f][0-9a-f][[:space:]]\)\{4\}[[:space:]]*b" |
grep -v '\<__start_initialization_multiplatform>' |