| From 167964af2155599b9d1612c500644f520abc5b87 Mon Sep 17 00:00:00 2001 |
| From: Maurizio Lombardi <mlombard@redhat.com> |
| Date: Fri, 15 Nov 2019 17:37:27 +0100 |
| Subject: [PATCH] scsi: scsi_debug: num_tgts must be >= 0 |
| |
| commit aa5334c4f3014940f11bf876e919c956abef4089 upstream. |
| |
| Passing the parameter "num_tgts=-1" will start an infinite loop that |
| exhausts the system memory |
| |
| Link: https://lore.kernel.org/r/20191115163727.24626-1-mlombard@redhat.com |
| Signed-off-by: Maurizio Lombardi <mlombard@redhat.com> |
| Acked-by: Douglas Gilbert <dgilbert@interlog.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c |
| index d323523f5f9d..32965ec76965 100644 |
| --- a/drivers/scsi/scsi_debug.c |
| +++ b/drivers/scsi/scsi_debug.c |
| @@ -5263,6 +5263,11 @@ static int __init scsi_debug_init(void) |
| return -EINVAL; |
| } |
| |
| + if (sdebug_num_tgts < 0) { |
| + pr_err("num_tgts must be >= 0\n"); |
| + return -EINVAL; |
| + } |
| + |
| if (sdebug_guard > 1) { |
| pr_err("guard must be 0 or 1\n"); |
| return -EINVAL; |
| -- |
| 2.7.4 |
| |
