blob: 5877163d71b471a1e1774e474ca82058bc6b7326 [file] [log] [blame]
From 054c1ef0e45b173c4d116388dd80961d71c90d6c Mon Sep 17 00:00:00 2001
From: Masahiro Yamada <>
Date: Mon, 30 Dec 2019 22:20:06 +0900
Subject: [PATCH] fix 'bad variable name' error
commit cc976614f59bd8e45de8ce988a6bcb5de711d994 upstream.
Prior to commit 858805b336be ("kbuild: add $(BASH) to run scripts with
bash-extension"), this shell script was almost always run by bash since
bash is usually installed on the system by default.
Now, this script is run by sh, which might be a symlink to dash. On such
distributions, the following code emits an error:
local dev=`LC_ALL=C ls -l "${location}"`
You can reproduce the build error, for example by setting
GEN usr/initramfs_data.cpio.gz
./usr/ 131: local: 1: bad variable name
make[1]: *** [usr/Makefile:61: usr/initramfs_data.cpio.gz] Error 2
This is because `LC_ALL=C ls -l "${location}"` contains spaces.
Surrounding it with double-quotes fixes the error.
Fixes: 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension")
Reported-by: Jory A. Pratt <>
Signed-off-by: Masahiro Yamada <>
Signed-off-by: Paul Gortmaker <>
diff --git a/usr/ b/usr/
index 0aad760fcd8c..2bbac73e6477 100755
--- a/usr/
+++ b/usr/
@@ -128,7 +128,7 @@ parse() {
str="${ftype} ${name} ${location} ${str}"
- local dev=`LC_ALL=C ls -l "${location}"`
+ local dev="`LC_ALL=C ls -l "${location}"`"
local maj=`field 5 ${dev}`
local min=`field 6 ${dev}`