| From 74c3347f76e620edf1b3f9648c83b9333cd5a8ae Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Tue, 3 Dec 2019 12:45:09 +0300 |
| Subject: [PATCH] scsi: iscsi: qla4xxx: fix double free in probe |
| |
| commit fee92f25777789d73e1936b91472e9c4644457c8 upstream. |
| |
| On this error path we call qla4xxx_mem_free() and then the caller also |
| calls qla4xxx_free_adapter() which calls qla4xxx_mem_free(). It leads to a |
| couple double frees: |
| |
| drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->chap_dma_pool' double freed |
| drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->fw_ddb_dma_pool' double freed |
| |
| Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx") |
| Link: https://lore.kernel.org/r/20191203094421.hw7ex7qr3j2rbsmx@kili.mountain |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c |
| index 8c674eca09f1..2323432a0edb 100644 |
| --- a/drivers/scsi/qla4xxx/ql4_os.c |
| +++ b/drivers/scsi/qla4xxx/ql4_os.c |
| @@ -4275,7 +4275,6 @@ static int qla4xxx_mem_alloc(struct scsi_qla_host *ha) |
| return QLA_SUCCESS; |
| |
| mem_alloc_error_exit: |
| - qla4xxx_mem_free(ha); |
| return QLA_ERROR; |
| } |
| |
| -- |
| 2.7.4 |
| |
