| From 3170e0f708f5379a8b090923191fc2fdd15d39e3 Mon Sep 17 00:00:00 2001 |
| From: Roman Bolshakov <r.bolshakov@yadro.com> |
| Date: Mon, 25 Nov 2019 19:56:56 +0300 |
| Subject: [PATCH] scsi: qla2xxx: Don't call qlt_async_event twice |
| |
| commit 2c2f4bed9b6299e6430a65a29b5d27b8763fdf25 upstream. |
| |
| MBA_PORT_UPDATE generates duplicate log lines in target mode because |
| qlt_async_event is called twice. Drop the calls within the case as the |
| function will be called right after the switch statement. |
| |
| Cc: Quinn Tran <qutran@marvell.com> |
| Link: https://lore.kernel.org/r/20191125165702.1013-8-r.bolshakov@yadro.com |
| Acked-by: Himanshu Madhani <hmadhani@marvel.com> |
| Reviewed-by: Hannes Reinecke <hare@suse.de> |
| Tested-by: Hannes Reinecke <hare@suse.de> |
| Acked-by: Himanshu Madhani <hmadhani@marvell.com> |
| Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c |
| index 78aec50abe0f..ecc886cc6d10 100644 |
| --- a/drivers/scsi/qla2xxx/qla_isr.c |
| +++ b/drivers/scsi/qla2xxx/qla_isr.c |
| @@ -1062,8 +1062,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb) |
| ql_dbg(ql_dbg_async, vha, 0x5011, |
| "Asynchronous PORT UPDATE ignored %04x/%04x/%04x.\n", |
| mb[1], mb[2], mb[3]); |
| - |
| - qlt_async_event(mb[0], vha, mb); |
| break; |
| } |
| |
| @@ -1080,8 +1078,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb) |
| set_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags); |
| set_bit(LOCAL_LOOP_UPDATE, &vha->dpc_flags); |
| set_bit(VP_CONFIG_OK, &vha->vp_flags); |
| - |
| - qlt_async_event(mb[0], vha, mb); |
| break; |
| |
| case MBA_RSCN_UPDATE: /* State Change Registration */ |
| -- |
| 2.7.4 |
| |
