blob: 6064730b37cd9842bb40efad897f9d67d563eb0e [file] [log] [blame]
From 1d354fe55d4b9f487772e2d09d31b15e1a20e2dd Mon Sep 17 00:00:00 2001
From: Roman Bolshakov <>
Date: Mon, 25 Nov 2019 19:56:53 +0300
Subject: [PATCH] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work
commit 600954e6f2df695434887dfc6a99a098859990cf upstream.
del_work is already initialized inside qla2x00_alloc_fcport, there's no
need to overwrite it. Indeed, it might prevent complete traversal of
workqueue list.
Fixes: a01c77d2cbc45 ("scsi: qla2xxx: Move session delete to driver work queue")
Cc: Quinn Tran <>
Acked-by: Himanshu Madhani <>
Reviewed-by: Hannes Reinecke <>
Tested-by: Hannes Reinecke <>
Reviewed-by: Bart Van Assche <>
Signed-off-by: Roman Bolshakov <>
Signed-off-by: Martin K. Petersen <>
Signed-off-by: Paul Gortmaker <>
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 1d410444f4e7..58527053c1cb 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -1270,7 +1270,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port *sess)
"Scheduling sess %p for deletion %8phC\n",
sess, sess->port_name);
- INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn);
WARN_ON(!queue_work(sess->vha->hw->wq, &sess->del_work));