| From a088bd50057d30aac9ad4e554c8777b9c45eec44 Mon Sep 17 00:00:00 2001 |
| From: Olga Kornievskaia <olga.kornievskaia@gmail.com> |
| Date: Wed, 4 Dec 2019 15:13:54 -0500 |
| Subject: [PATCH] NFSD fixing possible null pointer derefering in copy offload |
| |
| commit 18f428d4e2f7eff162d80b2b21689496c4e82afd upstream. |
| |
| Static checker revealed possible error path leading to possible |
| NULL pointer dereferencing. |
| |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Fixes: e0639dc5805a: ("NFSD introduce async copy feature") |
| Signed-off-by: Olga Kornievskaia <kolga@netapp.com> |
| Signed-off-by: J. Bruce Fields <bfields@redhat.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c |
| index c187d892e656..bff38e0ff0cf 100644 |
| --- a/fs/nfsd/nfs4proc.c |
| +++ b/fs/nfsd/nfs4proc.c |
| @@ -1303,7 +1303,8 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, |
| out: |
| return status; |
| out_err: |
| - cleanup_async_copy(async_copy); |
| + if (async_copy) |
| + cleanup_async_copy(async_copy); |
| goto out; |
| } |
| |
| -- |
| 2.7.4 |
| |
