| From 2ebb58a7a9428f0395fc7ebef4f3a24e4c0b1265 Mon Sep 17 00:00:00 2001 |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| Date: Mon, 4 Nov 2019 10:15:02 -0800 |
| Subject: [PATCH] reset: brcmstb: Remove resource checks |
| |
| commit ce89d8d3a70fa530e16f0b0f8994385a214cd0c0 upstream. |
| |
| The use of IS_ALIGNED() is incorrect, the typical resource we pass looks |
| like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will |
| get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively |
| not equal to 0, same goes with the size. These two checks would make the |
| driver fail probing. |
| |
| Remove the resource checks, since there should be no constraint on the |
| base addresse or size. |
| |
| Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver") |
| Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/reset/reset-brcmstb.c b/drivers/reset/reset-brcmstb.c |
| index a608f445dad6..f213264c8567 100644 |
| --- a/drivers/reset/reset-brcmstb.c |
| +++ b/drivers/reset/reset-brcmstb.c |
| @@ -91,12 +91,6 @@ static int brcmstb_reset_probe(struct platform_device *pdev) |
| return -ENOMEM; |
| |
| res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| - if (!IS_ALIGNED(res->start, SW_INIT_BANK_SIZE) || |
| - !IS_ALIGNED(resource_size(res), SW_INIT_BANK_SIZE)) { |
| - dev_err(kdev, "incorrect register range\n"); |
| - return -EINVAL; |
| - } |
| - |
| priv->base = devm_ioremap_resource(kdev, res); |
| if (IS_ERR(priv->base)) |
| return PTR_ERR(priv->base); |
| -- |
| 2.7.4 |
| |
