| From 0565b308ec637cf1cf6d8126e2f3182cf0ad4d7c Mon Sep 17 00:00:00 2001 |
| From: Davide Caratti <dcaratti@redhat.com> |
| Date: Tue, 11 Feb 2020 19:33:40 +0100 |
| Subject: [PATCH] net/sched: flower: add missing validation of TCA_FLOWER_FLAGS |
| |
| commit e2debf0852c4d66ba1a8bde12869b196094c70a7 upstream. |
| |
| unlike other classifiers that can be offloaded (i.e. users can set flags |
| like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of |
| netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry |
| to fl_policy. |
| |
| Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support") |
| Signed-off-by: Davide Caratti <dcaratti@redhat.com> |
| Acked-by: Jiri Pirko <jiri@mellanox.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c |
| index dfd5856916bd..a9ef122916fd 100644 |
| --- a/net/sched/cls_flower.c |
| +++ b/net/sched/cls_flower.c |
| @@ -704,6 +704,7 @@ static const struct nla_policy fl_policy[TCA_FLOWER_MAX + 1] = { |
| [TCA_FLOWER_KEY_ENC_IP_TTL_MASK] = { .type = NLA_U8 }, |
| [TCA_FLOWER_KEY_ENC_OPTS] = { .type = NLA_NESTED }, |
| [TCA_FLOWER_KEY_ENC_OPTS_MASK] = { .type = NLA_NESTED }, |
| + [TCA_FLOWER_FLAGS] = { .type = NLA_U32 }, |
| }; |
| |
| static const struct nla_policy |
| -- |
| 2.7.4 |
| |