| From 6f98873073e506f10d132d77baad59387484b2c6 Mon Sep 17 00:00:00 2001 |
| From: Davide Caratti <dcaratti@redhat.com> |
| Date: Tue, 11 Feb 2020 19:33:39 +0100 |
| Subject: [PATCH] net/sched: matchall: add missing validation of |
| TCA_MATCHALL_FLAGS |
| |
| commit 1afa3cc90f8fb745c777884d79eaa1001d6927a6 upstream. |
| |
| unlike other classifiers that can be offloaded (i.e. users can set flags |
| like 'skip_hw' and 'skip_sw'), 'cls_matchall' doesn't validate the size |
| of netlink attribute 'TCA_MATCHALL_FLAGS' provided by user: add a proper |
| entry to mall_policy. |
| |
| Fixes: b87f7936a932 ("net/sched: Add match-all classifier hw offloading.") |
| Signed-off-by: Davide Caratti <dcaratti@redhat.com> |
| Acked-by: Jiri Pirko <jiri@mellanox.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c |
| index a75c230c67df..2a72a061c41b 100644 |
| --- a/net/sched/cls_matchall.c |
| +++ b/net/sched/cls_matchall.c |
| @@ -157,6 +157,7 @@ static void *mall_get(struct tcf_proto *tp, u32 handle) |
| static const struct nla_policy mall_policy[TCA_MATCHALL_MAX + 1] = { |
| [TCA_MATCHALL_UNSPEC] = { .type = NLA_UNSPEC }, |
| [TCA_MATCHALL_CLASSID] = { .type = NLA_U32 }, |
| + [TCA_MATCHALL_FLAGS] = { .type = NLA_U32 }, |
| }; |
| |
| static int mall_set_parms(struct net *net, struct tcf_proto *tp, |
| -- |
| 2.7.4 |
| |
