| From 250c030a68bbf2bd73e1689b180b46fe5ecaaa96 Mon Sep 17 00:00:00 2001 |
| From: Jason Gunthorpe <jgg@mellanox.com> |
| Date: Fri, 21 Feb 2020 15:20:26 +0000 |
| Subject: [PATCH] RMDA/cm: Fix missing ib_cm_destroy_id() in |
| ib_cm_insert_listen() |
| |
| commit c14dfddbd869bf0c2bafb7ef260c41d9cebbcfec upstream. |
| |
| The algorithm pre-allocates a cm_id since allocation cannot be done while |
| holding the cm.lock spinlock, however it doesn't free it on one error |
| path, leading to a memory leak. |
| |
| Fixes: 067b171b8679 ("IB/cm: Share listening CM IDs") |
| Link: https://lore.kernel.org/r/20200221152023.GA8680@ziepe.ca |
| Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c |
| index 5920c0085d35..319e4b4ae639 100644 |
| --- a/drivers/infiniband/core/cm.c |
| +++ b/drivers/infiniband/core/cm.c |
| @@ -1228,6 +1228,7 @@ struct ib_cm_id *ib_cm_insert_listen(struct ib_device *device, |
| /* Sharing an ib_cm_id with different handlers is not |
| * supported */ |
| spin_unlock_irqrestore(&cm.lock, flags); |
| + ib_destroy_cm_id(cm_id); |
| return ERR_PTR(-EINVAL); |
| } |
| atomic_inc(&cm_id_priv->refcount); |
| -- |
| 2.7.4 |
| |
