| From 66c1aa064372cd3c1911e2b567a498a46d5555ff Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Tue, 3 Mar 2020 13:16:08 +0300 |
| Subject: [PATCH] hwmon: (adt7462) Fix an error return in ADT7462_REG_VOLT() |
| |
| commit 44f2f882909fedfc3a56e4b90026910456019743 upstream. |
| |
| This is only called from adt7462_update_device(). The caller expects it |
| to return zero on error. I fixed a similar issue earlier in commit |
| a4bf06d58f21 ("hwmon: (adt7462) ADT7462_REG_VOLT_MAX() should return 0") |
| but I missed this one. |
| |
| Fixes: c0b4e3ab0c76 ("adt7462: new hwmon driver") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> |
| Link: https://lore.kernel.org/r/20200303101608.kqjwfcazu2ylhi2a@kili.mountain |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c |
| index 9632e2e3c4bb..319a0519ebdb 100644 |
| --- a/drivers/hwmon/adt7462.c |
| +++ b/drivers/hwmon/adt7462.c |
| @@ -413,7 +413,7 @@ static int ADT7462_REG_VOLT(struct adt7462_data *data, int which) |
| return 0x95; |
| break; |
| } |
| - return -ENODEV; |
| + return 0; |
| } |
| |
| /* Provide labels for sysfs */ |
| -- |
| 2.7.4 |
| |
