blob: b78fd7bab08326731988d23252c01175f32a651f [file] [log] [blame]
From a2846d8c4e5f843cfe8d6b057616868486744497 Mon Sep 17 00:00:00 2001
From: Michal Swiatkowski <>
Date: Thu, 13 Feb 2020 13:31:24 -0800
Subject: [PATCH] ice: Don't tell the OS that link is going down
commit 8a55c08d3bbc9ffc9639f69f742e59ebd99f913b upstream.
Remove code that tell the OS that link is going down when user
change flow control via ethtool. When link is up it isn't certain
that link goes down after 0x0605 aq command. If link doesn't go
down, OS thinks that link is down, but physical link is up. To
reset this state user have to take interface down and up.
If link goes down after 0x0605 command, FW send information
about that and after that driver tells the OS that the link goes
down. So this code in ethtool is unnecessary.
Signed-off-by: Michal Swiatkowski <>
Tested-by: Andrew Bowers <>
Signed-off-by: Jeff Kirsher <>
Signed-off-by: Paul Gortmaker <>
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index 1341fde8d53f..4c81d77cf5cc 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -2032,13 +2032,6 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)
return -EINVAL;
- /* Tell the OS link is going down, the link will go back up when fw
- * says it is ready asynchronously
- */
- ice_print_link_msg(vsi, false);
- netif_carrier_off(netdev);
- netif_tx_stop_all_queues(netdev);
/* Set the FC mode and only restart AN if link is up */
status = ice_set_fc(pi, &aq_failures, link_up);