| From 31223ca3880c55ce856180e62f5e049b36ac0d26 Mon Sep 17 00:00:00 2001 |
| From: Stephan Gerhold <stephan@gerhold.net> |
| Date: Fri, 14 Feb 2020 12:03:24 +0100 |
| Subject: [PATCH] iio: magnetometer: ak8974: Fix negative raw values in sysfs |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| commit b500c086e4110829a308c23e83a7cdc65b26228a upstream. |
| |
| At the moment, reading from in_magn_*_raw in sysfs tends to return |
| large values around 65000, even though the output of ak8974 is actually |
| limited to ±32768. This happens because the value is never converted |
| to the signed 16-bit integer variant. |
| |
| Add an explicit cast to s16 to fix this. |
| |
| Fixes: 7c94a8b2ee8c ("iio: magn: add a driver for AK8974") |
| Signed-off-by: Stephan Gerhold <stephan@gerhold.net> |
| Reviewed-by: Linus Waleij <linus.walleij@linaro.org> |
| Cc: <Stable@vger.kernel.org> |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c |
| index fc7e910f8e8b..d32996702110 100644 |
| --- a/drivers/iio/magnetometer/ak8974.c |
| +++ b/drivers/iio/magnetometer/ak8974.c |
| @@ -564,7 +564,7 @@ static int ak8974_read_raw(struct iio_dev *indio_dev, |
| * We read all axes and discard all but one, for optimized |
| * reading, use the triggered buffer. |
| */ |
| - *val = le16_to_cpu(hw_values[chan->address]); |
| + *val = (s16)le16_to_cpu(hw_values[chan->address]); |
| |
| ret = IIO_VAL_INT; |
| } |
| -- |
| 2.7.4 |
| |
