blob: 96438413036d7f167ccc6a620df531ad34be304d [file] [log] [blame]
From e18ef0068440572854ee9e82583bd54a658bdd7f Mon Sep 17 00:00:00 2001
From: Florian Fainelli <>
Date: Thu, 20 Feb 2020 15:34:53 -0800
Subject: [PATCH] net: phy: Avoid multiple suspends
commit 503ba7c6961034ff0047707685644cad9287c226 upstream.
It is currently possible for a PHY device to be suspended as part of a
network device driver's suspend call while it is still being attached to
that net_device, either via phy_suspend() or implicitly via phy_stop().
Later on, when the MDIO bus controller get suspended, we would attempt
to suspend again the PHY because it is still attached to a network
This is both a waste of time and creates an opportunity for improper
clock/power management bugs to creep in.
Fixes: 803dd9c77ac3 ("net: phy: avoid suspending twice a PHY")
Signed-off-by: Florian Fainelli <>
Signed-off-by: David S. Miller <>
Signed-off-by: Paul Gortmaker <>
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 862815495b20..54288b1b11df 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -246,7 +246,7 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
* MDIO bus driver and clock gated at this point.
if (!netdev)
- return !phydev->suspended;
+ goto out;
if (netdev->wol_enabled)
return false;
@@ -266,7 +266,8 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
if (device_may_wakeup(&netdev->dev))
return false;
- return true;
+ return !phydev->suspended;
static int mdio_bus_phy_suspend(struct device *dev)