| From d65e877c0783f19fad7b0954f4c4fbe5330e8bf4 Mon Sep 17 00:00:00 2001 |
| From: Leonard Crestez <leonard.crestez@nxp.com> |
| Date: Thu, 20 Feb 2020 18:29:37 +0200 |
| Subject: [PATCH] pinctrl: imx: scu: Align imx sc msg structs to 4 |
| |
| commit 4c48e549f39f8ed10cf8a0b6cb96f5eddf0391ce upstream. |
| |
| The imx SC api strongly assumes that messages are composed out of |
| 4-bytes words but some of our message structs have odd sizeofs. |
| |
| This produces many oopses with CONFIG_KASAN=y. |
| |
| Fix by marking with __aligned(4). |
| |
| Fixes: b96eea718bf6 ("pinctrl: fsl: add scu based pinctrl support") |
| Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> |
| Link: https://lore.kernel.org/r/bd7ad5fd755739a6d8d5f4f65e03b3ca4f457bd2.1582216144.git.leonard.crestez@nxp.com |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c |
| index 73bf1d9f9cc6..23cf04bdfc55 100644 |
| --- a/drivers/pinctrl/freescale/pinctrl-scu.c |
| +++ b/drivers/pinctrl/freescale/pinctrl-scu.c |
| @@ -23,12 +23,12 @@ struct imx_sc_msg_req_pad_set { |
| struct imx_sc_rpc_msg hdr; |
| u32 val; |
| u16 pad; |
| -} __packed; |
| +} __packed __aligned(4); |
| |
| struct imx_sc_msg_req_pad_get { |
| struct imx_sc_rpc_msg hdr; |
| u16 pad; |
| -} __packed; |
| +} __packed __aligned(4); |
| |
| struct imx_sc_msg_resp_pad_get { |
| struct imx_sc_rpc_msg hdr; |
| -- |
| 2.7.4 |
| |