| From 6f49a7863c83411608c383b2618fbf9325920277 Mon Sep 17 00:00:00 2001 |
| From: Qiujun Huang <hqjagain@gmail.com> |
| Date: Thu, 26 Mar 2020 21:18:50 +0800 |
| Subject: [PATCH] staging: wlan-ng: fix use-after-free Read in |
| hfa384x_usbin_callback |
| |
| commit 1165dd73e811a07d947aee218510571f516081f6 upstream. |
| |
| We can't handle the case length > WLAN_DATA_MAXLEN. |
| Because the size of rxfrm->data is WLAN_DATA_MAXLEN(2312), and we can't |
| read more than that. |
| |
| Thanks-to: Hillf Danton <hdanton@sina.com> |
| Reported-and-tested-by: syzbot+7d42d68643a35f71ac8a@syzkaller.appspotmail.com |
| Signed-off-by: Qiujun Huang <hqjagain@gmail.com> |
| Cc: stable <stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/20200326131850.17711-1-hqjagain@gmail.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c |
| index ab734534093b..91aaff02a59e 100644 |
| --- a/drivers/staging/wlan-ng/hfa384x_usb.c |
| +++ b/drivers/staging/wlan-ng/hfa384x_usb.c |
| @@ -3494,6 +3494,8 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, |
| WLAN_HDR_A4_LEN + WLAN_DATA_MAXLEN + WLAN_CRC_LEN)) { |
| pr_debug("overlen frm: len=%zd\n", |
| skblen - sizeof(struct p80211_caphdr)); |
| + |
| + return; |
| } |
| |
| skb = dev_alloc_skb(skblen); |
| -- |
| 2.7.4 |
| |
