| From 12de1ee9b6fc3b9d87b3a98d9fb3cd18bac2d26e Mon Sep 17 00:00:00 2001 |
| From: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Date: Tue, 17 Mar 2020 08:22:11 +0200 |
| Subject: [PATCH] stm class: sys-t: Fix the use of time_after() |
| |
| commit 283f87c0d5d32b4a5c22636adc559bca82196ed3 upstream. |
| |
| The operands of time_after() are in a wrong order in both instances in |
| the sys-t driver. Fix that. |
| |
| Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Fixes: 39f10239df75 ("stm class: p_sys-t: Add support for CLOCKSYNC packets") |
| Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support") |
| Cc: stable@vger.kernel.org # v4.20+ |
| Link: https://lore.kernel.org/r/20200317062215.15598-3-alexander.shishkin@linux.intel.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/hwtracing/stm/p_sys-t.c b/drivers/hwtracing/stm/p_sys-t.c |
| index b178a5495b67..360b5c03df95 100644 |
| --- a/drivers/hwtracing/stm/p_sys-t.c |
| +++ b/drivers/hwtracing/stm/p_sys-t.c |
| @@ -238,7 +238,7 @@ static struct configfs_attribute *sys_t_policy_attrs[] = { |
| static inline bool sys_t_need_ts(struct sys_t_output *op) |
| { |
| if (op->node.ts_interval && |
| - time_after(op->ts_jiffies + op->node.ts_interval, jiffies)) { |
| + time_after(jiffies, op->ts_jiffies + op->node.ts_interval)) { |
| op->ts_jiffies = jiffies; |
| |
| return true; |
| @@ -250,8 +250,8 @@ static inline bool sys_t_need_ts(struct sys_t_output *op) |
| static bool sys_t_need_clock_sync(struct sys_t_output *op) |
| { |
| if (op->node.clocksync_interval && |
| - time_after(op->clocksync_jiffies + op->node.clocksync_interval, |
| - jiffies)) { |
| + time_after(jiffies, |
| + op->clocksync_jiffies + op->node.clocksync_interval)) { |
| op->clocksync_jiffies = jiffies; |
| |
| return true; |
| -- |
| 2.7.4 |
| |
