blob: 8b5a1f6bb0b4b38ec0c9d471d563a24106c233e4 [file] [log] [blame]
From bc9e0fff290f6f08a59c8a84ea91f67854d39243 Mon Sep 17 00:00:00 2001
From: "Gustavo A. R. Silva" <>
Date: Tue, 22 Jan 2019 14:18:42 -0600
Subject: [PATCH] MIPS: OCTEON: irq: Fix potential NULL pointer dereference
commit 792a402c2840054533ef56279c212ef6da87d811 upstream.
There is a potential NULL pointer dereference in case kzalloc()
fails and returns NULL.
Fix this by adding a NULL check on *cd*
This bug was detected with the help of Coccinelle.
Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
Signed-off-by: Gustavo A. R. Silva <>
Signed-off-by: Thomas Bogendoerfer <>
Signed-off-by: Paul Gortmaker <>
diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
index f97be32bf699..3ad1f76c063a 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -2199,6 +2199,9 @@ static int octeon_irq_cib_map(struct irq_domain *d,
cd = kzalloc(sizeof(*cd), GFP_KERNEL);
+ if (!cd)
+ return -ENOMEM;
cd->host_data = host_data;
cd->bit = hw;