blob: 758e2636c2cffde709e089cb5d3e0af77bdf3407 [file] [log] [blame]
From 89f990e9d917942a6120dbef64987181d25a6d4d Mon Sep 17 00:00:00 2001
From: Michael Wang <>
Date: Wed, 18 Mar 2020 10:15:15 +0800
Subject: [PATCH] sched: Avoid scale real weight down to zero
commit 26cf52229efc87e2effa9d788f9b33c40fb3358a upstream.
During our testing, we found a case that shares no longer
working correctly, the cgroup topology is like:
/sys/fs/cgroup/cpu/A (shares=102400)
/sys/fs/cgroup/cpu/A/B (shares=2)
/sys/fs/cgroup/cpu/A/B/C (shares=1024)
/sys/fs/cgroup/cpu/D (shares=1024)
/sys/fs/cgroup/cpu/D/E (shares=1024)
/sys/fs/cgroup/cpu/D/E/F (shares=1024)
The same benchmark is running in group C & F, no other tasks are
running, the benchmark is capable to consumed all the CPUs.
We suppose the group C will win more CPU resources since it could
enjoy all the shares of group A, but it's F who wins much more.
The reason is because we have group B with shares as 2, since
A->cfs_rq.load.weight == B->se.load.weight == B->shares/nr_cpus,
so A->cfs_rq.load.weight become very small.
And in calc_group_shares() we calculate shares as:
load = max(scale_load_down(cfs_rq->load.weight), cfs_rq->avg.load_avg);
shares = (tg_shares * load) / tg_weight;
Since the 'cfs_rq->load.weight' is too small, the load become 0
after scale down, although 'tg_shares' is 102400, shares of the se
which stand for group A on root cfs_rq become 2.
While the se of D on root cfs_rq is far more bigger than 2, so it
wins the battle.
Thus when scale_load_down() scale real weight down to 0, it's no
longer telling the real story, the caller will have the wrong
information and the calculation will be buggy.
This patch add check in scale_load_down(), so the real weight will
be >= MIN_SHARES after scale, after applied the group C wins as
Suggested-by: Peter Zijlstra <>
Signed-off-by: Michael Wang <>
Signed-off-by: Peter Zijlstra (Intel) <>
Reviewed-by: Vincent Guittot <>
Signed-off-by: Paul Gortmaker <>
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 0c0ed23f315a..2a63f48194c0 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -124,7 +124,13 @@ static inline void cpu_load_update_active(struct rq *this_rq) { }
#ifdef CONFIG_64BIT
# define scale_load(w) ((w) << SCHED_FIXEDPOINT_SHIFT)
-# define scale_load_down(w) ((w) >> SCHED_FIXEDPOINT_SHIFT)
+# define scale_load_down(w) \
+({ \
+ unsigned long __w = (w); \
+ if (__w) \
+ __w = max(2UL, __w >> SCHED_FIXEDPOINT_SHIFT); \
+ __w; \
# define scale_load(w) (w)