| From 9eb75dea70af35a0c1f46ad77b6ba4f7f0952ecd Mon Sep 17 00:00:00 2001 |
| From: Ajay Singh <ajay.kathat@microchip.com> |
| Date: Fri, 21 Feb 2020 11:30:20 +0000 |
| Subject: [PATCH] staging: wilc1000: avoid double unlocking of 'wilc->hif_cs' |
| mutex |
| |
| commit 6c411581caef6e3b2c286871641018364c6db50a upstream. |
| |
| Possible double unlocking of 'wilc->hif_cs' mutex was identified by |
| smatch [1]. Removed the extra call to release_bus() in |
| wilc_wlan_handle_txq() which was missed in earlier commit fdc2ac1aafc6 |
| ("staging: wilc1000: support suspend/resume functionality"). |
| |
| [1]. https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/NOEVW7C3GV74EWXJO3XX6VT2NKVB2HMT/ |
| |
| Reported-by: kbuild test robot <lkp@intel.com> |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> |
| Link: https://lore.kernel.org/r/20200221170120.15739-1-ajay.kathat@microchip.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c |
| index 95eaf8fdf4f2..c38a0023b1f1 100644 |
| --- a/drivers/staging/wilc1000/wilc_wlan.c |
| +++ b/drivers/staging/wilc1000/wilc_wlan.c |
| @@ -586,7 +586,6 @@ int wilc_wlan_handle_txq(struct net_device *dev, u32 *txq_count) |
| entries = ((reg >> 3) & 0x3f); |
| break; |
| } |
| - release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP); |
| } while (--timeout); |
| if (timeout <= 0) { |
| ret = func->hif_write_reg(wilc, WILC_HOST_VMM_CTL, 0x0); |
| -- |
| 2.7.4 |
| |
