blob: 4e223da2153c9760dd1aa47af313077d0c4d1093 [file] [log] [blame]
From 33a6ede8bff598819e78de8f6146e7aa2c27594d Mon Sep 17 00:00:00 2001
From: Neil Armstrong <>
Date: Fri, 21 Feb 2020 10:15:31 +0100
Subject: [PATCH] usb: dwc3: core: add support for disabling SS instances in
park mode
commit 7ba6b09fda5e0cb741ee56f3264665e0edc64822 upstream.
In certain circumstances, the XHCI SuperSpeed instance in park mode
can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
load on the single XHCI SuperSpeed instance, the controller can crash like:
xhci-hcd xHCI host not responding to stop endpoint command.
xhci-hcd Host halt failed, -110
xhci-hcd xHCI host controller not responding, assume dead
xhci-hcd xHCI host not responding to stop endpoint command.
hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
xhci-hcd HC died; cleaning up
usb 2-1.1-port1: cannot reset (err = -22)
Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
the issue. The bit is described as :
"When this bit is set to '1' all SS bus instances in park mode are disabled"
Synopsys explains:
The GUCTL1.PARKMODE_DISABLE_SS is only available in
dwc_usb3 controller running in host mode.
This should not be set for other IPs.
This can be disabled by default based on IP, but I recommend to have a
property to enable this feature for devices that need this.
CC: Dongjin Kim <>
Cc: Jianxin Pan <>
Cc: Thinh Nguyen <>
Cc: Jun Li <>
Reported-by: Tim <>
Signed-off-by: Neil Armstrong <>
Signed-off-by: Felipe Balbi <>
Signed-off-by: Paul Gortmaker <>
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index c745eb1f3a6e..c91596efa3e8 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -982,6 +982,9 @@ static int dwc3_core_init(struct dwc3 *dwc)
if (dwc->dis_tx_ipgap_linecheck_quirk)
+ if (dwc->parkmode_disable_ss_quirk)
dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
@@ -1292,6 +1295,8 @@ static void dwc3_get_properties(struct dwc3 *dwc)
dwc->dis_tx_ipgap_linecheck_quirk = device_property_read_bool(dev,
+ dwc->parkmode_disable_ss_quirk = device_property_read_bool(dev,
+ "snps,parkmode-disable-ss-quirk");
dwc->tx_de_emphasis_quirk = device_property_read_bool(dev,
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 1cb48000e4d9..21ac0174c861 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -249,6 +249,7 @@
/* Global User Control 1 Register */
@@ -1024,6 +1025,8 @@ struct dwc3_scratchpad_array {
* change quirk.
* @dis_tx_ipgap_linecheck_quirk: set if we disable u2mac linestate
* check during HS transmit.
+ * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
+ * instances in park mode.
* @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
* @tx_de_emphasis: Tx de-emphasis value
* 0 - -6dB de-emphasis
@@ -1211,6 +1214,7 @@ struct dwc3 {
unsigned dis_u2_freeclk_exists_quirk:1;
unsigned dis_del_phy_power_chg_quirk:1;
unsigned dis_tx_ipgap_linecheck_quirk:1;
+ unsigned parkmode_disable_ss_quirk:1;
unsigned tx_de_emphasis_quirk:1;
unsigned tx_de_emphasis:2;