| From 638bc7de2415d3f4430d62477f675cb2421c7609 Mon Sep 17 00:00:00 2001 |
| From: Chuhong Yuan <hslester96@gmail.com> |
| Date: Thu, 28 May 2020 18:20:37 +0800 |
| Subject: [PATCH] NFC: st21nfca: add missed kfree_skb() in an error path |
| |
| commit 3decabdc714ca56c944f4669b4cdec5c2c1cea23 upstream. |
| |
| st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. |
| Add the missed function call to fix it. |
| |
| Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode") |
| Signed-off-by: Chuhong Yuan <hslester96@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/nfc/st21nfca/dep.c |
| index 60acdfd1cb8c..856a10c293f8 100644 |
| --- a/drivers/nfc/st21nfca/dep.c |
| +++ b/drivers/nfc/st21nfca/dep.c |
| @@ -173,8 +173,10 @@ static int st21nfca_tm_send_atr_res(struct nfc_hci_dev *hdev, |
| memcpy(atr_res->gbi, atr_req->gbi, gb_len); |
| r = nfc_set_remote_general_bytes(hdev->ndev, atr_res->gbi, |
| gb_len); |
| - if (r < 0) |
| + if (r < 0) { |
| + kfree_skb(skb); |
| return r; |
| + } |
| } |
| |
| info->dep_info.curr_nfc_dep_pni = 0; |
| -- |
| 2.27.0 |
| |