| From e1cf1bcb5cb813a390716bb0abd3b087a1f69cb4 Mon Sep 17 00:00:00 2001 |
| From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
| Date: Fri, 22 May 2020 12:33:41 +0100 |
| Subject: [PATCH] nvmem: qfprom: remove incorrect write support |
| |
| commit 8d9eb0d6d59a5d7028c80a30831143d3e75515a7 upstream. |
| |
| qfprom has different address spaces for read and write. Reads are |
| always done from corrected address space, where as writes are done |
| on raw address space. |
| Writing to corrected address space is invalid and ignored, so it |
| does not make sense to have this support in the driver which only |
| supports corrected address space regions at the moment. |
| |
| Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") |
| Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
| Reviewed-by: Douglas Anderson <dianders@chromium.org> |
| Cc: stable <stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/20200522113341.7728-1-srinivas.kandagatla@linaro.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c |
| index d057f1bfb2e9..8a91717600be 100644 |
| --- a/drivers/nvmem/qfprom.c |
| +++ b/drivers/nvmem/qfprom.c |
| @@ -27,25 +27,11 @@ static int qfprom_reg_read(void *context, |
| return 0; |
| } |
| |
| -static int qfprom_reg_write(void *context, |
| - unsigned int reg, void *_val, size_t bytes) |
| -{ |
| - struct qfprom_priv *priv = context; |
| - u8 *val = _val; |
| - int i = 0, words = bytes; |
| - |
| - while (words--) |
| - writeb(*val++, priv->base + reg + i++); |
| - |
| - return 0; |
| -} |
| - |
| static struct nvmem_config econfig = { |
| .name = "qfprom", |
| .stride = 1, |
| .word_size = 1, |
| .reg_read = qfprom_reg_read, |
| - .reg_write = qfprom_reg_write, |
| }; |
| |
| static int qfprom_probe(struct platform_device *pdev) |
| -- |
| 2.27.0 |
| |
