blob: 11cf1d81b9306898428f805a4c8494b95da3c03c [file] [log] [blame]
From 4e78ac73757974b6ddf3b904d4c9502ad31c32dd Mon Sep 17 00:00:00 2001
From: Yuxuan Shui <>
Date: Wed, 27 May 2020 04:08:02 +0100
Subject: [PATCH] ovl: initialize error in ovl_copy_xattr
commit 520da69d265a91c6536c63851cbb8a53946974f0 upstream.
In ovl_copy_xattr, if all the xattrs to be copied are overlayfs private
xattrs, the copy loop will terminate without assigning anything to the
error variable, thus returning an uninitialized value.
If ovl_copy_xattr is called from ovl_clear_empty, this uninitialized error
value is put into a pointer by ERR_PTR(), causing potential invalid memory
accesses down the line.
This commit initialize error with 0. This is the correct value because when
there's no xattr to copy, because all xattrs are private, ovl_copy_xattr
should succeed.
This bug is discovered with the help of INIT_STACK_ALL and clang.
Signed-off-by: Yuxuan Shui <>
Fixes: 0956254a2d5b ("ovl: don't copy up opaqueness")
Cc: # v4.8
Signed-off-by: Alexander Potapenko <>
Signed-off-by: Miklos Szeredi <>
Signed-off-by: Paul Gortmaker <>
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index b801c6353100..ec5eca5a96f4 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -40,7 +40,7 @@ int ovl_copy_xattr(struct dentry *old, struct dentry *new)
ssize_t list_size, size, value_size = 0;
char *buf, *name, *value = NULL;
- int uninitialized_var(error);
+ int error = 0;
size_t slen;
if (!(old->d_inode->i_opflags & IOP_XATTR) ||