| From f09a490ce67d81022fbf693e425f38d59ce8d69b Mon Sep 17 00:00:00 2001 |
| From: Quentin Monnet <quentin.monnet@netronome.com> |
| Date: Thu, 15 Aug 2019 15:32:17 +0100 |
| Subject: [PATCH] tools: bpftool: fix argument for p_err() in BTF do_dump() |
| |
| commit ed4a3983cd3eb93aaf80de8d8a36efed808acff2 upstream. |
| |
| The last argument passed to one call to the p_err() function is not |
| correct, it should be "*argv" instead of "**argv". This may lead to a |
| segmentation fault error if BTF id cannot be parsed correctly. Let's fix |
| this. |
| |
| Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types") |
| Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com> |
| Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> |
| Signed-off-by: Alexei Starovoitov <ast@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c |
| index 7317438ecd9e..1fbf353364d6 100644 |
| --- a/tools/bpf/bpftool/btf.c |
| +++ b/tools/bpf/bpftool/btf.c |
| @@ -517,7 +517,7 @@ static int do_dump(int argc, char **argv) |
| |
| btf_id = strtoul(*argv, &endptr, 0); |
| if (*endptr) { |
| - p_err("can't parse %s as ID", **argv); |
| + p_err("can't parse %s as ID", *argv); |
| return -1; |
| } |
| NEXT_ARG(); |
| -- |
| 2.27.0 |
| |