| From fbba72747eaeb16230c84d2935c140a969b97cdb Mon Sep 17 00:00:00 2001 |
| From: Merlijn Wajer <merlijn@wizzup.org> |
| Date: Tue, 30 Jun 2020 11:47:40 -0700 |
| Subject: [PATCH] ARM: dts: n900: remove mmc1 card detect gpio |
| |
| commit ed3e98e919aaaa47e9d9f8a40c3f6f4a22577842 upstream. |
| |
| Instead, expose the key via the input framework, as SW_MACHINE_COVER |
| |
| The chip-detect GPIO is actually detecting if the cover is closed. |
| Technically it's possible to use the SD card with open cover. The |
| only downside is risk of battery falling out and user being able |
| to physically remove the card. |
| |
| The behaviour of SD card not being available when the device is |
| open is unexpected and creates more problems than it solves. There |
| is a high chance, that more people accidentally break their rootfs |
| by opening the case without physically removing the card. |
| |
| Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> |
| Acked-by: Tony Lindgren <tony@atomide.com> |
| Signed-off-by: Merlijn Wajer <merlijn@wizzup.org> |
| Link: https://lore.kernel.org/r/20200612125402.18393-3-merlijn@wizzup.org |
| Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts |
| index 7f2ddb78da5f..4227da71cc62 100644 |
| --- a/arch/arm/boot/dts/omap3-n900.dts |
| +++ b/arch/arm/boot/dts/omap3-n900.dts |
| @@ -105,6 +105,14 @@ |
| linux,code = <SW_FRONT_PROXIMITY>; |
| linux,can-disable; |
| }; |
| + |
| + machine_cover { |
| + label = "Machine Cover"; |
| + gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */ |
| + linux,input-type = <EV_SW>; |
| + linux,code = <SW_MACHINE_COVER>; |
| + linux,can-disable; |
| + }; |
| }; |
| |
| isp1707: isp1707 { |
| @@ -814,10 +822,6 @@ |
| pinctrl-0 = <&mmc1_pins>; |
| vmmc-supply = <&vmmc1>; |
| bus-width = <4>; |
| - /* For debugging, it is often good idea to remove this GPIO. |
| - It means you can remove back cover (to reboot by removing |
| - battery) and still use the MMC card. */ |
| - cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */ |
| }; |
| |
| /* most boards use vaux3, only some old versions use vmmc2 instead */ |
| -- |
| 2.27.0 |
| |
