| From 58a2254d418b6ce1cfaae84ff9541374b99a0c21 Mon Sep 17 00:00:00 2001 |
| From: Michael Tretter <m.tretter@pengutronix.de> |
| Date: Thu, 17 Aug 2017 12:43:07 +0200 |
| Subject: [PATCH] drm/debugfs: fix plain echo to connector "force" attribute |
| |
| commit c704b17071c4dc571dca3af4e4151dac51de081a upstream. |
| |
| Using plain echo to set the "force" connector attribute fails with |
| -EINVAL, because echo appends a newline to the output. |
| |
| Replace strcmp with sysfs_streq to also accept strings that end with a |
| newline. |
| |
| v2: use sysfs_streq instead of stripping trailing whitespace |
| |
| Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> |
| Reviewed-by: Jani Nikula <jani.nikula@intel.com> |
| Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20170817104307.17124-1-m.tretter@pengutronix.de |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c |
| index f8468eae0503..b531649e4ee2 100644 |
| --- a/drivers/gpu/drm/drm_debugfs.c |
| +++ b/drivers/gpu/drm/drm_debugfs.c |
| @@ -354,13 +354,13 @@ static ssize_t connector_write(struct file *file, const char __user *ubuf, |
| |
| buf[len] = '\0'; |
| |
| - if (!strcmp(buf, "on")) |
| + if (sysfs_streq(buf, "on")) |
| connector->force = DRM_FORCE_ON; |
| - else if (!strcmp(buf, "digital")) |
| + else if (sysfs_streq(buf, "digital")) |
| connector->force = DRM_FORCE_ON_DIGITAL; |
| - else if (!strcmp(buf, "off")) |
| + else if (sysfs_streq(buf, "off")) |
| connector->force = DRM_FORCE_OFF; |
| - else if (!strcmp(buf, "unspecified")) |
| + else if (sysfs_streq(buf, "unspecified")) |
| connector->force = DRM_FORCE_UNSPECIFIED; |
| else |
| return -EINVAL; |
| -- |
| 2.27.0 |
| |