| From 30e8e602003a82a2685feca13d1653a8809897eb Mon Sep 17 00:00:00 2001 |
| From: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Date: Mon, 30 Sep 2019 15:11:47 -0300 |
| Subject: [PATCH] perf annotate: Fix the signedness of failure returns |
| |
| commit 28f4417c3333940b242af03d90214f713bbef232 upstream. |
| |
| Callers of symbol__annotate() expect a errno value or some other |
| extended error value range in symbol__strerror_disassemble() to |
| convert to a proper error string, fix it when propagating a failure to |
| find the arch specific annotation routines via arch__find(arch_name). |
| |
| Reported-by: Russell King - ARM Linux admin <linux@armlinux.org.uk> |
| Cc: Adrian Hunter <adrian.hunter@intel.com> |
| Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Cc: Jiri Olsa <jolsa@kernel.org> |
| Cc: Namhyung Kim <namhyung@kernel.org> |
| Cc: Peter Zijlstra <peterz@infradead.org>, |
| Cc: Will Deacon <will@kernel.org> |
| Link: https://lkml.kernel.org/n/tip-o0k6dw7cas0vvmjjvgsyvu1i@git.kernel.org |
| Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c |
| index 63c171290dc2..a439740f703e 100644 |
| --- a/tools/perf/util/annotate.c |
| +++ b/tools/perf/util/annotate.c |
| @@ -2064,7 +2064,7 @@ int symbol__annotate(struct symbol *sym, struct map *map, |
| |
| args.arch = arch = arch__find(arch_name); |
| if (arch == NULL) |
| - return -ENOTSUP; |
| + return ENOTSUP; |
| |
| if (parch) |
| *parch = arch; |
| -- |
| 2.7.4 |
| |
