| From 7b48f0ba4e1457f65a13010ac355475053141e21 Mon Sep 17 00:00:00 2001 |
| From: Wei Yongjun <weiyongjun1@huawei.com> |
| Date: Wed, 30 Oct 2019 03:40:46 +0000 |
| Subject: [PATCH] usb: gadget: configfs: Fix missing spin_lock_init() |
| |
| commit 093edc2baad2c258b1f55d1ab9c63c2b5ae67e42 upstream. |
| |
| The driver allocates the spinlock but not initialize it. |
| Use spin_lock_init() on it to initialize it correctly. |
| |
| This is detected by Coccinelle semantic patch. |
| |
| Fixes: 1a1c851bbd70 ("usb: gadget: configfs: fix concurrent issue between composite APIs") |
| Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> |
| Cc: stable <stable@vger.kernel.org> |
| Reviewed-by: Peter Chen <peter.chen@nxp.com> |
| Link: https://lore.kernel.org/r/20191030034046.188808-1-weiyongjun1@huawei.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c |
| index 33852c2b29d1..ab9ac48a751a 100644 |
| --- a/drivers/usb/gadget/configfs.c |
| +++ b/drivers/usb/gadget/configfs.c |
| @@ -1544,6 +1544,7 @@ static struct config_group *gadgets_make( |
| gi->composite.resume = NULL; |
| gi->composite.max_speed = USB_SPEED_SUPER; |
| |
| + spin_lock_init(&gi->spinlock); |
| mutex_init(&gi->lock); |
| INIT_LIST_HEAD(&gi->string_list); |
| INIT_LIST_HEAD(&gi->available_func); |
| -- |
| 2.7.4 |
| |
