| From 478a17dc9cd20fd102d01d4d035d27da2769fb48 Mon Sep 17 00:00:00 2001 |
| From: Peng Fan <peng.fan@nxp.com> |
| Date: Mon, 9 Dec 2019 08:19:55 +0000 |
| Subject: [PATCH] clk: imx: pll14xx: fix clk_pll14xx_wait_lock |
| |
| commit c3a5fd15ed0c1494435e4e35fbee734ae46b5073 upstream. |
| |
| The usage of readl_poll_timeout is wrong, the 3rd parameter(cond) |
| should be "val & LOCK_STATUS" not "val & LOCK_TIMEOUT_US", |
| It is not check whether the pll locked, LOCK_STATUS reflects the mask, |
| not LOCK_TIMEOUT_US. |
| |
| Fixes: 8646d4dcc7fb ("clk: imx: Add PLLs driver for imx8mm soc") |
| Cc: <stable@vger.kernel.org> |
| Reviewed-by: Abel Vesa <abel.vesa@nxp.com> |
| Signed-off-by: Peng Fan <peng.fan@nxp.com> |
| Signed-off-by: Shawn Guo <shawnguo@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c |
| index 7a815ec76aa5..d43b4a3c0de8 100644 |
| --- a/drivers/clk/imx/clk-pll14xx.c |
| +++ b/drivers/clk/imx/clk-pll14xx.c |
| @@ -153,7 +153,7 @@ static int clk_pll14xx_wait_lock(struct clk_pll14xx *pll) |
| { |
| u32 val; |
| |
| - return readl_poll_timeout(pll->base, val, val & LOCK_TIMEOUT_US, 0, |
| + return readl_poll_timeout(pll->base, val, val & LOCK_STATUS, 0, |
| LOCK_TIMEOUT_US); |
| } |
| |
| -- |
| 2.7.4 |
| |