| From c3c381264e3c17ecd50d064cee357bb5e1623e9f Mon Sep 17 00:00:00 2001 |
| From: Chuhong Yuan <hslester96@gmail.com> |
| Date: Wed, 16 Oct 2019 22:25:40 +0800 |
| Subject: [PATCH] staging: iio: ad9834: add a check for devm_clk_get |
| |
| commit a96de139301385e5992768c0f60240ddfbb33325 upstream. |
| |
| ad9834_probe misses a check for devm_clk_get and may cause problems. |
| Add a check like what ad9832 does to fix it. |
| |
| Signed-off-by: Chuhong Yuan <hslester96@gmail.com> |
| Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c |
| index 6de3cd7363d7..c8bf480a5b30 100644 |
| --- a/drivers/staging/iio/frequency/ad9834.c |
| +++ b/drivers/staging/iio/frequency/ad9834.c |
| @@ -417,6 +417,10 @@ static int ad9834_probe(struct spi_device *spi) |
| st = iio_priv(indio_dev); |
| mutex_init(&st->lock); |
| st->mclk = devm_clk_get(&spi->dev, NULL); |
| + if (IS_ERR(st->mclk)) { |
| + ret = PTR_ERR(st->mclk); |
| + goto error_disable_reg; |
| + } |
| |
| ret = clk_prepare_enable(st->mclk); |
| if (ret) { |
| -- |
| 2.7.4 |
| |