| From 1d354fe55d4b9f487772e2d09d31b15e1a20e2dd Mon Sep 17 00:00:00 2001 |
| From: Roman Bolshakov <r.bolshakov@yadro.com> |
| Date: Mon, 25 Nov 2019 19:56:53 +0300 |
| Subject: [PATCH] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work |
| |
| commit 600954e6f2df695434887dfc6a99a098859990cf upstream. |
| |
| del_work is already initialized inside qla2x00_alloc_fcport, there's no |
| need to overwrite it. Indeed, it might prevent complete traversal of |
| workqueue list. |
| |
| Fixes: a01c77d2cbc45 ("scsi: qla2xxx: Move session delete to driver work queue") |
| Cc: Quinn Tran <qutran@marvell.com> |
| Link: https://lore.kernel.org/r/20191125165702.1013-5-r.bolshakov@yadro.com |
| Acked-by: Himanshu Madhani <hmadhani@marvell.com> |
| Reviewed-by: Hannes Reinecke <hare@suse.de> |
| Tested-by: Hannes Reinecke <hare@suse.de> |
| Reviewed-by: Bart Van Assche <bvanassche@acm.org> |
| Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c |
| index 1d410444f4e7..58527053c1cb 100644 |
| --- a/drivers/scsi/qla2xxx/qla_target.c |
| +++ b/drivers/scsi/qla2xxx/qla_target.c |
| @@ -1270,7 +1270,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port *sess) |
| "Scheduling sess %p for deletion %8phC\n", |
| sess, sess->port_name); |
| |
| - INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn); |
| WARN_ON(!queue_work(sess->vha->hw->wq, &sess->del_work)); |
| } |
| |
| -- |
| 2.7.4 |
| |
