| From d027d585047625d8b59f62aef421212d715026c4 Mon Sep 17 00:00:00 2001 |
| From: Hewenliang <hewenliang4@huawei.com> |
| Date: Mon, 9 Dec 2019 01:35:49 -0500 |
| Subject: [PATCH] tools lib traceevent: Fix memory leakage in filter_event |
| |
| commit f84ae29a6169318f9c929720c49d96323d2bbab9 upstream. |
| |
| It is necessary to call free_arg(arg) when add_filter_type() returns NULL |
| in filter_event(). |
| |
| Signed-off-by: Hewenliang <hewenliang4@huawei.com> |
| Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> |
| Cc: Feilong Lin <linfeilong@huawei.com> |
| Cc: Tzvetomir Stoyanov <tstoyanov@vmware.com> |
| Link: http://lore.kernel.org/lkml/20191209063549.59941-1-hewenliang4@huawei.com |
| Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c |
| index f3cbf86e51ac..20eed719542e 100644 |
| --- a/tools/lib/traceevent/parse-filter.c |
| +++ b/tools/lib/traceevent/parse-filter.c |
| @@ -1228,8 +1228,10 @@ filter_event(struct tep_event_filter *filter, struct tep_event *event, |
| } |
| |
| filter_type = add_filter_type(filter, event->id); |
| - if (filter_type == NULL) |
| + if (filter_type == NULL) { |
| + free_arg(arg); |
| return TEP_ERRNO__MEM_ALLOC_FAILED; |
| + } |
| |
| if (filter_type->filter) |
| free_arg(filter_type->filter); |
| -- |
| 2.7.4 |
| |