| From 86b8534db0ae1df3a730f60ec1176429b137a37f Mon Sep 17 00:00:00 2001 |
| From: Raed Salem <raeds@mellanox.com> |
| Date: Tue, 24 Dec 2019 09:54:45 +0200 |
| Subject: [PATCH] net/mlx5: IPsec, Fix esp modify function attribute |
| |
| commit 0dc2c534f17c05bed0622b37a744bc38b48ca88a upstream. |
| |
| The function mlx5_fpga_esp_validate_xfrm_attrs is wrongly used |
| with negative negation as zero value indicates success but it |
| used as failure return value instead. |
| |
| Fix by remove the unary not negation operator. |
| |
| Fixes: 05564d0ae075 ("net/mlx5: Add flow-steering commands for FPGA IPSec implementation") |
| Signed-off-by: Raed Salem <raeds@mellanox.com> |
| Reviewed-by: Boris Pismenny <borisp@mellanox.com> |
| Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c |
| index 52c47d3dd5a5..6cf6a2f533dc 100644 |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c |
| @@ -1476,7 +1476,7 @@ int mlx5_fpga_esp_modify_xfrm(struct mlx5_accel_esp_xfrm *xfrm, |
| if (!memcmp(&xfrm->attrs, attrs, sizeof(xfrm->attrs))) |
| return 0; |
| |
| - if (!mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) { |
| + if (mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) { |
| mlx5_core_warn(mdev, "Tried to create an esp with unsupported attrs\n"); |
| return -EOPNOTSUPP; |
| } |
| -- |
| 2.7.4 |
| |
