| From 9f5bd875f2e789343f31ba14f0d56e05965ad0e9 Mon Sep 17 00:00:00 2001 |
| From: Phong Tran <tranmanphong@gmail.com> |
| Date: Wed, 27 Nov 2019 00:55:26 +0700 |
| Subject: [PATCH] b43legacy: Fix -Wcast-function-type |
| |
| commit 475eec112e4267232d10f4afe2f939a241692b6c upstream. |
| |
| correct usage prototype of callback in tasklet_init(). |
| Report by https://github.com/KSPP/linux/issues/20 |
| |
| Tested-by: Larry Finger <Larry.Finger@lwfinger.net> |
| Signed-off-by: Phong Tran <tranmanphong@gmail.com> |
| Reviewed-by: Kees Cook <keescook@chromium.org> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c |
| index 4325e91736eb..8b6b657c4b85 100644 |
| --- a/drivers/net/wireless/broadcom/b43legacy/main.c |
| +++ b/drivers/net/wireless/broadcom/b43legacy/main.c |
| @@ -1275,8 +1275,9 @@ static void handle_irq_ucode_debug(struct b43legacy_wldev *dev) |
| } |
| |
| /* Interrupt handler bottom-half */ |
| -static void b43legacy_interrupt_tasklet(struct b43legacy_wldev *dev) |
| +static void b43legacy_interrupt_tasklet(unsigned long data) |
| { |
| + struct b43legacy_wldev *dev = (struct b43legacy_wldev *)data; |
| u32 reason; |
| u32 dma_reason[ARRAY_SIZE(dev->dma_reason)]; |
| u32 merged_dma_reason = 0; |
| @@ -3741,7 +3742,7 @@ static int b43legacy_one_core_attach(struct ssb_device *dev, |
| b43legacy_set_status(wldev, B43legacy_STAT_UNINIT); |
| wldev->bad_frames_preempt = modparam_bad_frames_preempt; |
| tasklet_init(&wldev->isr_tasklet, |
| - (void (*)(unsigned long))b43legacy_interrupt_tasklet, |
| + b43legacy_interrupt_tasklet, |
| (unsigned long)wldev); |
| if (modparam_pio) |
| wldev->__using_pio = true; |
| -- |
| 2.7.4 |
| |
